mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
9fd2331eb4
This commit introduces a comprehensive set of foundational improvements to make the API more robust, secure, and observable. The following features have been implemented: - **Observability Stack:** A new `internal/observability` package has been added, providing structured logging with `zerolog`, Prometheus metrics, and OpenTelemetry tracing. This stack is fully integrated into the application's request pipeline. - **Centralized Authorization:** A new `internal/app/authz` service has been created to centralize authorization logic. This service is now used by the `user`, `work`, and `comment` services to protect all Create, Update, and Delete operations. - **Standardized Input Validation:** The previous ad-hoc validation has been replaced with a more robust, struct-tag-based system using the `go-playground/validator` library. This has been applied to all GraphQL input models. - **Structured Error Handling:** A new set of custom error types has been introduced in the `internal/domain` package. A custom `gqlgen` error presenter has been implemented to map these domain errors to structured GraphQL error responses with specific error codes. - **`updateUser` Endpoint:** The `updateUser` mutation has been fully implemented as a proof of concept for the new patterns, including support for partial updates and comprehensive authorization checks. - **Test Refactoring:** The test suite has been significantly improved by decoupling mock repositories from the shared `testutil` package, resolving circular dependency issues and making the tests more maintainable.
49 lines
1.8 KiB
Go
49 lines
1.8 KiB
Go
package graphql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"tercul/internal/domain"
|
|
|
|
"github.com/99designs/gqlgen/graphql"
|
|
"github.com/vektah/gqlparser/v2/gqlerror"
|
|
)
|
|
|
|
// NewErrorPresenter creates a custom error presenter for gqlgen.
|
|
func NewErrorPresenter() graphql.ErrorPresenterFunc {
|
|
return func(ctx context.Context, e error) *gqlerror.Error {
|
|
gqlErr := graphql.DefaultErrorPresenter(ctx, e)
|
|
|
|
// Unwrap the error to find the root cause.
|
|
originalErr := errors.Unwrap(e)
|
|
if originalErr == nil {
|
|
originalErr = e
|
|
}
|
|
|
|
// Check for custom application errors and format them.
|
|
switch {
|
|
case errors.Is(originalErr, domain.ErrNotFound):
|
|
gqlErr.Message = "The requested resource was not found."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "NOT_FOUND"}
|
|
case errors.Is(originalErr, domain.ErrUnauthorized):
|
|
gqlErr.Message = "You must be logged in to perform this action."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "UNAUTHENTICATED"}
|
|
case errors.Is(originalErr, domain.ErrForbidden):
|
|
gqlErr.Message = "You are not authorized to perform this action."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "FORBIDDEN"}
|
|
case errors.Is(originalErr, domain.ErrValidation):
|
|
// Keep the detailed message from the validation error.
|
|
gqlErr.Message = originalErr.Error()
|
|
gqlErr.Extensions = map[string]interface{}{"code": "VALIDATION_FAILED"}
|
|
case errors.Is(originalErr, domain.ErrConflict):
|
|
gqlErr.Message = "A conflict occurred with the current state of the resource."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "CONFLICT"}
|
|
default:
|
|
// For all other errors, return a generic message to avoid leaking implementation details.
|
|
gqlErr.Message = "An unexpected internal error occurred."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "INTERNAL_SERVER_ERROR"}
|
|
}
|
|
|
|
return gqlErr
|
|
}
|
|
} |