mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
c2e9a118e2
This commit significantly increases the test coverage across the application and fixes several underlying bugs that were discovered while writing the new tests. The key changes include: - **New Tests:** Added extensive integration and unit tests for GraphQL resolvers, application services, and data repositories, substantially increasing the test coverage for packages like `graphql`, `user`, `translation`, and `analytics`. - **Authorization Bug Fixes:** - Fixed a critical bug where a user creating a `Work` was not correctly associated as its author, causing subsequent permission failures. - Corrected the authorization logic in `authz.Service` to properly check for entity ownership by non-admin users. - **Test Refactoring:** - Refactored numerous test suites to use `testify/mock` instead of manual mocks, improving test clarity and maintainability. - Isolated integration tests by creating a fresh admin user and token for each test run, eliminating test pollution. - Centralized domain errors into `internal/domain/errors.go` and updated repositories to use them, making error handling more consistent. - **Code Quality Improvements:** - Replaced manual mock implementations with `testify/mock` for better consistency. - Cleaned up redundant and outdated test files. These changes stabilize the test suite, improve the overall quality of the codebase, and move the project closer to the goal of 80% test coverage.
78 lines
2.3 KiB
Go
78 lines
2.3 KiB
Go
package sql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"tercul/internal/domain"
|
|
"tercul/internal/platform/config"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
type bookRepository struct {
|
|
*BaseRepositoryImpl[domain.Book]
|
|
db *gorm.DB
|
|
tracer trace.Tracer
|
|
}
|
|
|
|
// NewBookRepository creates a new BookRepository.
|
|
func NewBookRepository(db *gorm.DB, cfg *config.Config) domain.BookRepository {
|
|
return &bookRepository{
|
|
BaseRepositoryImpl: NewBaseRepositoryImpl[domain.Book](db, cfg),
|
|
db: db,
|
|
tracer: otel.Tracer("book.repository"),
|
|
}
|
|
}
|
|
|
|
// ListByAuthorID finds books by author ID
|
|
func (r *bookRepository) ListByAuthorID(ctx context.Context, authorID uint) ([]domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByAuthorID")
|
|
defer span.End()
|
|
var books []domain.Book
|
|
if err := r.db.WithContext(ctx).Joins("JOIN book_authors ON book_authors.book_id = books.id").
|
|
Where("book_authors.author_id = ?", authorID).
|
|
Find(&books).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return books, nil
|
|
}
|
|
|
|
// ListByPublisherID finds books by publisher ID
|
|
func (r *bookRepository) ListByPublisherID(ctx context.Context, publisherID uint) ([]domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByPublisherID")
|
|
defer span.End()
|
|
var books []domain.Book
|
|
if err := r.db.WithContext(ctx).Where("publisher_id = ?", publisherID).Find(&books).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return books, nil
|
|
}
|
|
|
|
// ListByWorkID finds books by work ID
|
|
func (r *bookRepository) ListByWorkID(ctx context.Context, workID uint) ([]domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByWorkID")
|
|
defer span.End()
|
|
var books []domain.Book
|
|
if err := r.db.WithContext(ctx).Joins("JOIN book_works ON book_works.book_id = books.id").
|
|
Where("book_works.work_id = ?", workID).
|
|
Find(&books).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return books, nil
|
|
}
|
|
|
|
// FindByISBN finds a book by ISBN
|
|
func (r *bookRepository) FindByISBN(ctx context.Context, isbn string) (*domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "FindByISBN")
|
|
defer span.End()
|
|
var book domain.Book
|
|
if err := r.db.WithContext(ctx).Where("isbn = ?", isbn).First(&book).Error; err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return nil, domain.ErrEntityNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return &book, nil
|
|
} |