mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
c2e9a118e2
This commit significantly increases the test coverage across the application and fixes several underlying bugs that were discovered while writing the new tests. The key changes include: - **New Tests:** Added extensive integration and unit tests for GraphQL resolvers, application services, and data repositories, substantially increasing the test coverage for packages like `graphql`, `user`, `translation`, and `analytics`. - **Authorization Bug Fixes:** - Fixed a critical bug where a user creating a `Work` was not correctly associated as its author, causing subsequent permission failures. - Corrected the authorization logic in `authz.Service` to properly check for entity ownership by non-admin users. - **Test Refactoring:** - Refactored numerous test suites to use `testify/mock` instead of manual mocks, improving test clarity and maintainability. - Isolated integration tests by creating a fresh admin user and token for each test run, eliminating test pollution. - Centralized domain errors into `internal/domain/errors.go` and updated repositories to use them, making error handling more consistent. - **Code Quality Improvements:** - Replaced manual mock implementations with `testify/mock` for better consistency. - Cleaned up redundant and outdated test files. These changes stabilize the test suite, improve the overall quality of the codebase, and move the project closer to the goal of 80% test coverage.
64 lines
1.7 KiB
Go
64 lines
1.7 KiB
Go
package linguistics_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"tercul/internal/domain"
|
|
"tercul/internal/jobs/linguistics"
|
|
"tercul/internal/testutil"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
type AnalysisRepositoryTestSuite struct {
|
|
testutil.IntegrationTestSuite
|
|
repo linguistics.AnalysisRepository
|
|
}
|
|
|
|
func (s *AnalysisRepositoryTestSuite) SetupSuite() {
|
|
s.IntegrationTestSuite.SetupSuite(testutil.DefaultTestConfig())
|
|
s.repo = linguistics.NewGORMAnalysisRepository(s.DB)
|
|
}
|
|
|
|
func (s *AnalysisRepositoryTestSuite) SetupTest() {
|
|
s.IntegrationTestSuite.SetupTest()
|
|
}
|
|
|
|
func (s *AnalysisRepositoryTestSuite) TestGetAnalysisData() {
|
|
s.Run("should return the correct analysis data", func() {
|
|
// Arrange
|
|
work := s.CreateTestWork(s.AdminCtx, "Test Work", "en", "Test content")
|
|
textMetadata := &domain.TextMetadata{WorkID: work.ID, WordCount: 123}
|
|
readabilityScore := &domain.ReadabilityScore{WorkID: work.ID, Score: 45.6}
|
|
languageAnalysis := &domain.LanguageAnalysis{
|
|
WorkID: work.ID,
|
|
Analysis: domain.JSONB{
|
|
"sentiment": 0.5678,
|
|
},
|
|
}
|
|
s.DB.Create(textMetadata)
|
|
s.DB.Create(readabilityScore)
|
|
s.DB.Create(languageAnalysis)
|
|
|
|
// Act
|
|
returnedMetadata, returnedScore, returnedAnalysis, err := s.repo.GetAnalysisData(context.Background(), work.ID)
|
|
|
|
// Assert
|
|
s.Require().NoError(err)
|
|
s.Require().NotNil(returnedMetadata)
|
|
s.Require().NotNil(returnedScore)
|
|
s.Require().NotNil(returnedAnalysis)
|
|
|
|
s.Equal(textMetadata.WordCount, returnedMetadata.WordCount)
|
|
s.Equal(readabilityScore.Score, returnedScore.Score)
|
|
sentiment, ok := returnedAnalysis.Analysis["sentiment"].(float64)
|
|
s.Require().True(ok)
|
|
s.Equal(0.5678, sentiment)
|
|
})
|
|
}
|
|
|
|
func TestAnalysisRepository(t *testing.T) {
|
|
suite.Run(t, new(AnalysisRepositoryTestSuite))
|
|
}
|