mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 02:51:34 +00:00
c2e9a118e2
This commit significantly increases the test coverage across the application and fixes several underlying bugs that were discovered while writing the new tests. The key changes include: - **New Tests:** Added extensive integration and unit tests for GraphQL resolvers, application services, and data repositories, substantially increasing the test coverage for packages like `graphql`, `user`, `translation`, and `analytics`. - **Authorization Bug Fixes:** - Fixed a critical bug where a user creating a `Work` was not correctly associated as its author, causing subsequent permission failures. - Corrected the authorization logic in `authz.Service` to properly check for entity ownership by non-admin users. - **Test Refactoring:** - Refactored numerous test suites to use `testify/mock` instead of manual mocks, improving test clarity and maintainability. - Isolated integration tests by creating a fresh admin user and token for each test run, eliminating test pollution. - Centralized domain errors into `internal/domain/errors.go` and updated repositories to use them, making error handling more consistent. - **Code Quality Improvements:** - Replaced manual mock implementations with `testify/mock` for better consistency. - Cleaned up redundant and outdated test files. These changes stabilize the test suite, improve the overall quality of the codebase, and move the project closer to the goal of 80% test coverage.
52 lines
1.4 KiB
Go
52 lines
1.4 KiB
Go
package sql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"tercul/internal/domain"
|
|
"tercul/internal/platform/config"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
type editionRepository struct {
|
|
*BaseRepositoryImpl[domain.Edition]
|
|
db *gorm.DB
|
|
tracer trace.Tracer
|
|
}
|
|
|
|
// NewEditionRepository creates a new EditionRepository.
|
|
func NewEditionRepository(db *gorm.DB, cfg *config.Config) domain.EditionRepository {
|
|
return &editionRepository{
|
|
BaseRepositoryImpl: NewBaseRepositoryImpl[domain.Edition](db, cfg),
|
|
db: db,
|
|
tracer: otel.Tracer("edition.repository"),
|
|
}
|
|
}
|
|
|
|
// ListByBookID finds editions by book ID
|
|
func (r *editionRepository) ListByBookID(ctx context.Context, bookID uint) ([]domain.Edition, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByBookID")
|
|
defer span.End()
|
|
var editions []domain.Edition
|
|
if err := r.db.WithContext(ctx).Where("book_id = ?", bookID).Find(&editions).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return editions, nil
|
|
}
|
|
|
|
// FindByISBN finds an edition by ISBN
|
|
func (r *editionRepository) FindByISBN(ctx context.Context, isbn string) (*domain.Edition, error) {
|
|
ctx, span := r.tracer.Start(ctx, "FindByISBN")
|
|
defer span.End()
|
|
var edition domain.Edition
|
|
if err := r.db.WithContext(ctx).Where("isbn = ?", isbn).First(&edition).Error; err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return nil, domain.ErrEntityNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return &edition, nil
|
|
} |