mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
c2e9a118e2
This commit significantly increases the test coverage across the application and fixes several underlying bugs that were discovered while writing the new tests. The key changes include: - **New Tests:** Added extensive integration and unit tests for GraphQL resolvers, application services, and data repositories, substantially increasing the test coverage for packages like `graphql`, `user`, `translation`, and `analytics`. - **Authorization Bug Fixes:** - Fixed a critical bug where a user creating a `Work` was not correctly associated as its author, causing subsequent permission failures. - Corrected the authorization logic in `authz.Service` to properly check for entity ownership by non-admin users. - **Test Refactoring:** - Refactored numerous test suites to use `testify/mock` instead of manual mocks, improving test clarity and maintainability. - Isolated integration tests by creating a fresh admin user and token for each test run, eliminating test pollution. - Centralized domain errors into `internal/domain/errors.go` and updated repositories to use them, making error handling more consistent. - **Code Quality Improvements:** - Replaced manual mock implementations with `testify/mock` for better consistency. - Cleaned up redundant and outdated test files. These changes stabilize the test suite, improve the overall quality of the codebase, and move the project closer to the goal of 80% test coverage.
67 lines
2.0 KiB
Go
67 lines
2.0 KiB
Go
package sql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"tercul/internal/domain"
|
|
"tercul/internal/platform/config"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
type authorRepository struct {
|
|
*BaseRepositoryImpl[domain.Author]
|
|
db *gorm.DB
|
|
}
|
|
|
|
// NewAuthorRepository creates a new AuthorRepository.
|
|
func NewAuthorRepository(db *gorm.DB, cfg *config.Config) domain.AuthorRepository {
|
|
baseRepo := NewBaseRepositoryImpl[domain.Author](db, cfg)
|
|
return &authorRepository{
|
|
BaseRepositoryImpl: baseRepo,
|
|
db: db,
|
|
}
|
|
}
|
|
|
|
func (r *authorRepository) FindByName(ctx context.Context, name string) (*domain.Author, error) {
|
|
var author domain.Author
|
|
err := r.db.WithContext(ctx).Where("name = ?", name).First(&author).Error
|
|
if err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return nil, domain.ErrEntityNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return &author, nil
|
|
}
|
|
|
|
func (r *authorRepository) ListByWorkID(ctx context.Context, workID uint) ([]domain.Author, error) {
|
|
var authors []domain.Author
|
|
err := r.db.WithContext(ctx).Joins("JOIN work_authors ON work_authors.author_id = authors.id").
|
|
Where("work_authors.work_id = ?", workID).Find(&authors).Error
|
|
return authors, err
|
|
}
|
|
|
|
func (r *authorRepository) ListByBookID(ctx context.Context, bookID uint) ([]domain.Author, error) {
|
|
var authors []domain.Author
|
|
err := r.db.WithContext(ctx).Joins("JOIN book_authors ON book_authors.author_id = authors.id").
|
|
Where("book_authors.book_id = ?", bookID).Find(&authors).Error
|
|
return authors, err
|
|
}
|
|
|
|
func (r *authorRepository) ListByCountryID(ctx context.Context, countryID uint) ([]domain.Author, error) {
|
|
var authors []domain.Author
|
|
err := r.db.WithContext(ctx).Where("country_id = ?", countryID).Find(&authors).Error
|
|
return authors, err
|
|
}
|
|
|
|
func (r *authorRepository) GetWithTranslations(ctx context.Context, id uint) (*domain.Author, error) {
|
|
var author domain.Author
|
|
err := r.db.WithContext(ctx).Preload("Translations").First(&author, id).Error
|
|
if err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return nil, domain.ErrEntityNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return &author, nil
|
|
} |