mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
67 lines
1.9 KiB
Go
67 lines
1.9 KiB
Go
package enrichment
|
|
|
|
import (
|
|
"context"
|
|
"tercul/internal/domain"
|
|
"tercul/internal/domain/work"
|
|
)
|
|
|
|
// Service is the main entrypoint for the enrichment functionality.
|
|
// It orchestrates different enrichers for various domain entities.
|
|
type Service struct {
|
|
AuthorEnrichers []AuthorEnricher
|
|
WorkEnrichers []WorkEnricher
|
|
}
|
|
|
|
// NewService creates a new enrichment Service.
|
|
func NewService() *Service {
|
|
service := &Service{
|
|
AuthorEnrichers: []AuthorEnricher{},
|
|
WorkEnrichers: []WorkEnricher{},
|
|
}
|
|
service.RegisterAuthorEnricher(NewOpenLibraryAuthorEnricher())
|
|
return service
|
|
}
|
|
|
|
// AuthorEnricher defines the interface for enriching author data.
|
|
type AuthorEnricher interface {
|
|
Enrich(ctx context.Context, author *domain.Author) error
|
|
Name() string
|
|
}
|
|
|
|
// WorkEnricher defines the interface for enriching work data.
|
|
type WorkEnricher interface {
|
|
Enrich(ctx context.Context, work *work.Work) error
|
|
Name() string
|
|
}
|
|
|
|
// RegisterAuthorEnricher adds a new author enricher to the service.
|
|
func (s *Service) RegisterAuthorEnricher(enricher AuthorEnricher) {
|
|
s.AuthorEnrichers = append(s.AuthorEnrichers, enricher)
|
|
}
|
|
|
|
// RegisterWorkEnricher adds a new work enricher to the service.
|
|
func (s *Service) RegisterWorkEnricher(enricher WorkEnricher) {
|
|
s.WorkEnrichers = append(s.WorkEnrichers, enricher)
|
|
}
|
|
|
|
// EnrichAuthor iterates through registered author enrichers and applies them.
|
|
func (s *Service) EnrichAuthor(ctx context.Context, author *domain.Author) error {
|
|
for _, enricher := range s.AuthorEnrichers {
|
|
if err := enricher.Enrich(ctx, author); err != nil {
|
|
// In a real implementation, we might want to log errors but continue.
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// EnrichWork iterates through registered work enrichers and applies them.
|
|
func (s *Service) EnrichWork(ctx context.Context, work *work.Work) error {
|
|
for _, enricher := range s.WorkEnrichers {
|
|
if err := enricher.Enrich(ctx, work); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
} |