mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
78 lines
2.2 KiB
Go
78 lines
2.2 KiB
Go
package sql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"tercul/internal/domain"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
type bookRepository struct {
|
|
domain.BaseRepository[domain.Book]
|
|
db *gorm.DB
|
|
tracer trace.Tracer
|
|
}
|
|
|
|
// NewBookRepository creates a new BookRepository.
|
|
func NewBookRepository(db *gorm.DB) domain.BookRepository {
|
|
return &bookRepository{
|
|
BaseRepository: NewBaseRepositoryImpl[domain.Book](db),
|
|
db: db,
|
|
tracer: otel.Tracer("book.repository"),
|
|
}
|
|
}
|
|
|
|
// ListByAuthorID finds books by author ID
|
|
func (r *bookRepository) ListByAuthorID(ctx context.Context, authorID uint) ([]domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByAuthorID")
|
|
defer span.End()
|
|
var books []domain.Book
|
|
if err := r.db.WithContext(ctx).Joins("JOIN book_authors ON book_authors.book_id = books.id").
|
|
Where("book_authors.author_id = ?", authorID).
|
|
Find(&books).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return books, nil
|
|
}
|
|
|
|
// ListByPublisherID finds books by publisher ID
|
|
func (r *bookRepository) ListByPublisherID(ctx context.Context, publisherID uint) ([]domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByPublisherID")
|
|
defer span.End()
|
|
var books []domain.Book
|
|
if err := r.db.WithContext(ctx).Where("publisher_id = ?", publisherID).Find(&books).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return books, nil
|
|
}
|
|
|
|
// ListByWorkID finds books by work ID
|
|
func (r *bookRepository) ListByWorkID(ctx context.Context, workID uint) ([]domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByWorkID")
|
|
defer span.End()
|
|
var books []domain.Book
|
|
if err := r.db.WithContext(ctx).Joins("JOIN book_works ON book_works.book_id = books.id").
|
|
Where("book_works.work_id = ?", workID).
|
|
Find(&books).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return books, nil
|
|
}
|
|
|
|
// FindByISBN finds a book by ISBN
|
|
func (r *bookRepository) FindByISBN(ctx context.Context, isbn string) (*domain.Book, error) {
|
|
ctx, span := r.tracer.Start(ctx, "FindByISBN")
|
|
defer span.End()
|
|
var book domain.Book
|
|
if err := r.db.WithContext(ctx).Where("isbn = ?", isbn).First(&book).Error; err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return nil, ErrEntityNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return &book, nil
|
|
}
|