mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
59 lines
1.6 KiB
Go
59 lines
1.6 KiB
Go
package search
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"tercul/internal/app/localization"
|
|
"tercul/internal/domain/work"
|
|
"tercul/internal/platform/log"
|
|
"tercul/internal/platform/search"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/trace"
|
|
)
|
|
|
|
// IndexService pushes localized snapshots into Weaviate for search
|
|
type IndexService interface {
|
|
IndexWork(ctx context.Context, work work.Work) error
|
|
}
|
|
|
|
type indexService struct {
|
|
localization *localization.Service
|
|
weaviate search.WeaviateWrapper
|
|
tracer trace.Tracer
|
|
}
|
|
|
|
func NewIndexService(localization *localization.Service, weaviate search.WeaviateWrapper) IndexService {
|
|
return &indexService{
|
|
localization: localization,
|
|
weaviate: weaviate,
|
|
tracer: otel.Tracer("search.service"),
|
|
}
|
|
}
|
|
|
|
func (s *indexService) IndexWork(ctx context.Context, work work.Work) error {
|
|
ctx, span := s.tracer.Start(ctx, "IndexWork")
|
|
defer span.End()
|
|
logger := log.FromContext(ctx).With("work_id", work.ID)
|
|
logger.Debug("Indexing work")
|
|
|
|
// Get content from translation service
|
|
content, err := s.localization.Queries.GetWorkContent(ctx, work.ID, work.Language)
|
|
if err != nil {
|
|
logger.Error(err, "Failed to get work content for indexing")
|
|
// We can choose to index without content or return an error.
|
|
// For now, we'll log the error and continue indexing with empty content.
|
|
content = ""
|
|
}
|
|
|
|
err = s.weaviate.IndexWork(ctx, &work, content)
|
|
if err != nil {
|
|
logger.Error(err, "Failed to index work in Weaviate")
|
|
return err
|
|
}
|
|
logger.Info("Successfully indexed work")
|
|
return nil
|
|
}
|
|
|
|
func formatID(id uint) string { return fmt.Sprintf("%d", id) }
|