mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
c2e9a118e2
This commit significantly increases the test coverage across the application and fixes several underlying bugs that were discovered while writing the new tests. The key changes include: - **New Tests:** Added extensive integration and unit tests for GraphQL resolvers, application services, and data repositories, substantially increasing the test coverage for packages like `graphql`, `user`, `translation`, and `analytics`. - **Authorization Bug Fixes:** - Fixed a critical bug where a user creating a `Work` was not correctly associated as its author, causing subsequent permission failures. - Corrected the authorization logic in `authz.Service` to properly check for entity ownership by non-admin users. - **Test Refactoring:** - Refactored numerous test suites to use `testify/mock` instead of manual mocks, improving test clarity and maintainability. - Isolated integration tests by creating a fresh admin user and token for each test run, eliminating test pollution. - Centralized domain errors into `internal/domain/errors.go` and updated repositories to use them, making error handling more consistent. - **Code Quality Improvements:** - Replaced manual mock implementations with `testify/mock` for better consistency. - Cleaned up redundant and outdated test files. These changes stabilize the test suite, improve the overall quality of the codebase, and move the project closer to the goal of 80% test coverage.
57 lines
1.6 KiB
Go
57 lines
1.6 KiB
Go
package sql_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"tercul/internal/data/sql"
|
|
"tercul/internal/domain"
|
|
"tercul/internal/platform/config"
|
|
"tercul/internal/testutil"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
)
|
|
|
|
type MonetizationRepositoryTestSuite struct {
|
|
testutil.IntegrationTestSuite
|
|
MonetizationRepo domain.MonetizationRepository
|
|
}
|
|
|
|
func (s *MonetizationRepositoryTestSuite) SetupSuite() {
|
|
s.IntegrationTestSuite.SetupSuite(testutil.DefaultTestConfig())
|
|
cfg, err := config.LoadConfig()
|
|
s.Require().NoError(err)
|
|
s.MonetizationRepo = sql.NewMonetizationRepository(s.DB, cfg)
|
|
}
|
|
|
|
func (s *MonetizationRepositoryTestSuite) SetupTest() {
|
|
s.IntegrationTestSuite.SetupTest()
|
|
s.DB.Exec("DELETE FROM work_monetizations")
|
|
s.DB.Exec("DELETE FROM monetizations")
|
|
s.DB.Exec("DELETE FROM works")
|
|
}
|
|
|
|
func (s *MonetizationRepositoryTestSuite) TestAddMonetizationToWork() {
|
|
s.Run("should add a monetization to a work", func() {
|
|
// Arrange
|
|
work := s.CreateTestWork(s.AdminCtx, "Test Work", "en", "Test content")
|
|
monetization := &domain.Monetization{Amount: 10.0}
|
|
s.Require().NoError(s.DB.Create(monetization).Error)
|
|
|
|
// Act
|
|
err := s.MonetizationRepo.AddMonetizationToWork(context.Background(), work.ID, monetization.ID)
|
|
|
|
// Assert
|
|
s.Require().NoError(err)
|
|
|
|
// Verify that the association was created in the database
|
|
var foundWork domain.Work
|
|
err = s.DB.Preload("Monetizations").First(&foundWork, work.ID).Error
|
|
s.Require().NoError(err)
|
|
s.Require().Len(foundWork.Monetizations, 1)
|
|
s.Equal(monetization.ID, foundWork.Monetizations[0].ID)
|
|
})
|
|
}
|
|
|
|
func TestMonetizationRepository(t *testing.T) {
|
|
suite.Run(t, new(MonetizationRepositoryTestSuite))
|
|
} |