mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
78 lines
2.2 KiB
Go
78 lines
2.2 KiB
Go
package enrichment
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"tercul/internal/domain"
|
|
"tercul/internal/platform/openlibrary"
|
|
)
|
|
|
|
// OpenLibraryAuthorEnricher enriches author data from the Open Library API.
|
|
type OpenLibraryAuthorEnricher struct {
|
|
client *openlibrary.Client
|
|
}
|
|
|
|
// NewOpenLibraryAuthorEnricher creates a new OpenLibraryAuthorEnricher.
|
|
func NewOpenLibraryAuthorEnricher() *OpenLibraryAuthorEnricher {
|
|
return &OpenLibraryAuthorEnricher{
|
|
client: openlibrary.NewClient(),
|
|
}
|
|
}
|
|
|
|
// Name returns the name of the enricher.
|
|
func (e *OpenLibraryAuthorEnricher) Name() string {
|
|
return "openlibrary_author_enricher"
|
|
}
|
|
|
|
// Enrich fetches data from the Open Library API and enriches the author.
|
|
func (e *OpenLibraryAuthorEnricher) Enrich(ctx context.Context, author *domain.Author) error {
|
|
if author.OpenLibraryID == "" {
|
|
// No OLID to look up.
|
|
return nil
|
|
}
|
|
|
|
olAuthor, err := e.client.GetAuthor(ctx, author.OpenLibraryID)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get author from Open Library: %w", err)
|
|
}
|
|
|
|
if olAuthor.Bio != nil {
|
|
// The bio can be a string or a struct with a 'value' field.
|
|
if bioStr, ok := olAuthor.Bio.(string); ok {
|
|
// Find or create the English translation for the bio.
|
|
e.updateBioTranslation(author, bioStr)
|
|
} else if bioMap, ok := olAuthor.Bio.(map[string]interface{}); ok {
|
|
if bioValue, ok := bioMap["value"].(string); ok {
|
|
e.updateBioTranslation(author, bioValue)
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (e *OpenLibraryAuthorEnricher) updateBioTranslation(author *domain.Author, bio string) {
|
|
// This is a simplified implementation. A real one would need to handle
|
|
// creating or updating a translation record associated with the author.
|
|
// For now, we'll just append it to the author's existing bio if it's empty.
|
|
var bioTranslation *domain.Translation
|
|
for _, t := range author.Translations {
|
|
if t.TranslatableType == "authors" && t.Language == "en" {
|
|
bioTranslation = t
|
|
break
|
|
}
|
|
}
|
|
|
|
if bioTranslation == nil {
|
|
author.Translations = append(author.Translations, &domain.Translation{
|
|
Content: bio,
|
|
Language: "en",
|
|
TranslatableID: author.ID,
|
|
TranslatableType: "authors",
|
|
})
|
|
} else {
|
|
if bioTranslation.Content == "" {
|
|
bioTranslation.Content = bio
|
|
}
|
|
}
|
|
} |