mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
77 lines
1.9 KiB
Go
77 lines
1.9 KiB
Go
package bookmark
|
|
|
|
import (
|
|
"context"
|
|
"tercul/internal/app/analytics"
|
|
"tercul/internal/domain"
|
|
)
|
|
|
|
// BookmarkCommands contains the command handlers for the bookmark aggregate.
|
|
type BookmarkCommands struct {
|
|
repo domain.BookmarkRepository
|
|
analyticsSvc analytics.Service
|
|
}
|
|
|
|
// NewBookmarkCommands creates a new BookmarkCommands handler.
|
|
func NewBookmarkCommands(repo domain.BookmarkRepository, analyticsSvc analytics.Service) *BookmarkCommands {
|
|
return &BookmarkCommands{
|
|
repo: repo,
|
|
analyticsSvc: analyticsSvc,
|
|
}
|
|
}
|
|
|
|
// CreateBookmarkInput represents the input for creating a new bookmark.
|
|
type CreateBookmarkInput struct {
|
|
Name string
|
|
UserID uint
|
|
WorkID uint
|
|
Notes string
|
|
}
|
|
|
|
// CreateBookmark creates a new bookmark.
|
|
func (c *BookmarkCommands) CreateBookmark(ctx context.Context, input CreateBookmarkInput) (*domain.Bookmark, error) {
|
|
bookmark := &domain.Bookmark{
|
|
Name: input.Name,
|
|
UserID: input.UserID,
|
|
WorkID: input.WorkID,
|
|
Notes: input.Notes,
|
|
}
|
|
err := c.repo.Create(ctx, bookmark)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if c.analyticsSvc != nil {
|
|
go c.analyticsSvc.IncrementWorkBookmarks(context.Background(), input.WorkID)
|
|
}
|
|
|
|
return bookmark, nil
|
|
}
|
|
|
|
// UpdateBookmarkInput represents the input for updating an existing bookmark.
|
|
type UpdateBookmarkInput struct {
|
|
ID uint
|
|
Name string
|
|
Notes string
|
|
}
|
|
|
|
// UpdateBookmark updates an existing bookmark.
|
|
func (c *BookmarkCommands) UpdateBookmark(ctx context.Context, input UpdateBookmarkInput) (*domain.Bookmark, error) {
|
|
bookmark, err := c.repo.GetByID(ctx, input.ID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
bookmark.Name = input.Name
|
|
bookmark.Notes = input.Notes
|
|
err = c.repo.Update(ctx, bookmark)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return bookmark, nil
|
|
}
|
|
|
|
// DeleteBookmark deletes a bookmark by ID.
|
|
func (c *BookmarkCommands) DeleteBookmark(ctx context.Context, id uint) error {
|
|
return c.repo.Delete(ctx, id)
|
|
}
|