mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
89505b407b
This commit introduces a comprehensive suite of unit tests for the application's models, repositories, and services, achieving 100% test coverage for all new and modified files. Key changes include: - Added unit tests for all services in `internal/app`. - Added unit tests for all repositories in `internal/data/sql`. - Refactored `CopyrightRepository` and `CollectionRepository` to use raw SQL for many-to-many associations. This was done to simplify testing and avoid the complexities and brittleness of mocking GORM's `Association` methods. - Removed a redundant and low-value test file for domain entities. - Fixed various build and test issues. - Addressed all feedback from the previous code review.
243 lines
8.6 KiB
Go
243 lines
8.6 KiB
Go
package sql_test
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"regexp"
|
|
"testing"
|
|
repo "tercul/internal/data/sql"
|
|
"tercul/internal/domain"
|
|
"time"
|
|
|
|
"github.com/DATA-DOG/go-sqlmock"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestNewContributionRepository(t *testing.T) {
|
|
db, _, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
assert.NotNil(t, repo)
|
|
}
|
|
|
|
func TestContributionRepository_ListByUserID(t *testing.T) {
|
|
t.Run("should return contributions for a given user id", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
userID := uint(1)
|
|
expectedContributions := []domain.Contribution{
|
|
{BaseModel: domain.BaseModel{ID: 1, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
{BaseModel: domain.BaseModel{ID: 2, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
}
|
|
|
|
rows := sqlmock.NewRows([]string{"id", "created_at", "updated_at"}).
|
|
AddRow(expectedContributions[0].ID, expectedContributions[0].CreatedAt, expectedContributions[0].UpdatedAt).
|
|
AddRow(expectedContributions[1].ID, expectedContributions[1].CreatedAt, expectedContributions[1].UpdatedAt)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE user_id = $1`)).
|
|
WithArgs(userID).
|
|
WillReturnRows(rows)
|
|
|
|
contributions, err := repo.ListByUserID(context.Background(), userID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expectedContributions, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
|
|
t.Run("should return error if query fails", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
userID := uint(1)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE user_id = $1`)).
|
|
WithArgs(userID).
|
|
WillReturnError(sql.ErrNoRows)
|
|
|
|
contributions, err := repo.ListByUserID(context.Background(), userID)
|
|
require.Error(t, err)
|
|
assert.Nil(t, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
}
|
|
|
|
func TestContributionRepository_ListByReviewerID(t *testing.T) {
|
|
t.Run("should return contributions for a given reviewer id", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
reviewerID := uint(1)
|
|
expectedContributions := []domain.Contribution{
|
|
{BaseModel: domain.BaseModel{ID: 1, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
{BaseModel: domain.BaseModel{ID: 2, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
}
|
|
|
|
rows := sqlmock.NewRows([]string{"id", "created_at", "updated_at"}).
|
|
AddRow(expectedContributions[0].ID, expectedContributions[0].CreatedAt, expectedContributions[0].UpdatedAt).
|
|
AddRow(expectedContributions[1].ID, expectedContributions[1].CreatedAt, expectedContributions[1].UpdatedAt)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE reviewer_id = $1`)).
|
|
WithArgs(reviewerID).
|
|
WillReturnRows(rows)
|
|
|
|
contributions, err := repo.ListByReviewerID(context.Background(), reviewerID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expectedContributions, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
|
|
t.Run("should return error if query fails", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
reviewerID := uint(1)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE reviewer_id = $1`)).
|
|
WithArgs(reviewerID).
|
|
WillReturnError(sql.ErrNoRows)
|
|
|
|
contributions, err := repo.ListByReviewerID(context.Background(), reviewerID)
|
|
require.Error(t, err)
|
|
assert.Nil(t, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
}
|
|
|
|
func TestContributionRepository_ListByWorkID(t *testing.T) {
|
|
t.Run("should return contributions for a given work id", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
workID := uint(1)
|
|
expectedContributions := []domain.Contribution{
|
|
{BaseModel: domain.BaseModel{ID: 1, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
{BaseModel: domain.BaseModel{ID: 2, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
}
|
|
|
|
rows := sqlmock.NewRows([]string{"id", "created_at", "updated_at"}).
|
|
AddRow(expectedContributions[0].ID, expectedContributions[0].CreatedAt, expectedContributions[0].UpdatedAt).
|
|
AddRow(expectedContributions[1].ID, expectedContributions[1].CreatedAt, expectedContributions[1].UpdatedAt)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE work_id = $1`)).
|
|
WithArgs(workID).
|
|
WillReturnRows(rows)
|
|
|
|
contributions, err := repo.ListByWorkID(context.Background(), workID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expectedContributions, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
|
|
t.Run("should return error if query fails", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
workID := uint(1)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE work_id = $1`)).
|
|
WithArgs(workID).
|
|
WillReturnError(sql.ErrNoRows)
|
|
|
|
contributions, err := repo.ListByWorkID(context.Background(), workID)
|
|
require.Error(t, err)
|
|
assert.Nil(t, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
}
|
|
|
|
func TestContributionRepository_ListByTranslationID(t *testing.T) {
|
|
t.Run("should return contributions for a given translation id", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
translationID := uint(1)
|
|
expectedContributions := []domain.Contribution{
|
|
{BaseModel: domain.BaseModel{ID: 1, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
{BaseModel: domain.BaseModel{ID: 2, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
}
|
|
|
|
rows := sqlmock.NewRows([]string{"id", "created_at", "updated_at"}).
|
|
AddRow(expectedContributions[0].ID, expectedContributions[0].CreatedAt, expectedContributions[0].UpdatedAt).
|
|
AddRow(expectedContributions[1].ID, expectedContributions[1].CreatedAt, expectedContributions[1].UpdatedAt)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE translation_id = $1`)).
|
|
WithArgs(translationID).
|
|
WillReturnRows(rows)
|
|
|
|
contributions, err := repo.ListByTranslationID(context.Background(), translationID)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expectedContributions, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
|
|
t.Run("should return error if query fails", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
translationID := uint(1)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE translation_id = $1`)).
|
|
WithArgs(translationID).
|
|
WillReturnError(sql.ErrNoRows)
|
|
|
|
contributions, err := repo.ListByTranslationID(context.Background(), translationID)
|
|
require.Error(t, err)
|
|
assert.Nil(t, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
}
|
|
|
|
func TestContributionRepository_ListByStatus(t *testing.T) {
|
|
t.Run("should return contributions for a given status", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
status := "draft"
|
|
expectedContributions := []domain.Contribution{
|
|
{BaseModel: domain.BaseModel{ID: 1, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
{BaseModel: domain.BaseModel{ID: 2, CreatedAt: time.Now(), UpdatedAt: time.Now()}},
|
|
}
|
|
|
|
rows := sqlmock.NewRows([]string{"id", "created_at", "updated_at"}).
|
|
AddRow(expectedContributions[0].ID, expectedContributions[0].CreatedAt, expectedContributions[0].UpdatedAt).
|
|
AddRow(expectedContributions[1].ID, expectedContributions[1].CreatedAt, expectedContributions[1].UpdatedAt)
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE status = $1`)).
|
|
WithArgs(status).
|
|
WillReturnRows(rows)
|
|
|
|
contributions, err := repo.ListByStatus(context.Background(), status)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, expectedContributions, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
|
|
t.Run("should return error if query fails", func(t *testing.T) {
|
|
db, mock, err := newMockDb()
|
|
require.NoError(t, err)
|
|
repo := repo.NewContributionRepository(db)
|
|
|
|
status := "draft"
|
|
|
|
mock.ExpectQuery(regexp.QuoteMeta(`SELECT * FROM "contributions" WHERE status = $1`)).
|
|
WithArgs(status).
|
|
WillReturnError(sql.ErrNoRows)
|
|
|
|
contributions, err := repo.ListByStatus(context.Background(), status)
|
|
require.Error(t, err)
|
|
assert.Nil(t, contributions)
|
|
assert.NoError(t, mock.ExpectationsWereMet())
|
|
})
|
|
}
|