tercul-backend/internal/platform/auth/middleware.go
google-labs-jules[bot] 9fd2331eb4 feat: Implement production-ready API patterns
This commit introduces a comprehensive set of foundational improvements to make the API more robust, secure, and observable.

The following features have been implemented:

- **Observability Stack:** A new `internal/observability` package has been added, providing structured logging with `zerolog`, Prometheus metrics, and OpenTelemetry tracing. This stack is fully integrated into the application's request pipeline.

- **Centralized Authorization:** A new `internal/app/authz` service has been created to centralize authorization logic. This service is now used by the `user`, `work`, and `comment` services to protect all Create, Update, and Delete operations.

- **Standardized Input Validation:** The previous ad-hoc validation has been replaced with a more robust, struct-tag-based system using the `go-playground/validator` library. This has been applied to all GraphQL input models.

- **Structured Error Handling:** A new set of custom error types has been introduced in the `internal/domain` package. A custom `gqlgen` error presenter has been implemented to map these domain errors to structured GraphQL error responses with specific error codes.

- **`updateUser` Endpoint:** The `updateUser` mutation has been fully implemented as a proof of concept for the new patterns, including support for partial updates and comprehensive authorization checks.

- **Test Refactoring:** The test suite has been significantly improved by decoupling mock repositories from the shared `testutil` package, resolving circular dependency issues and making the tests more maintainable.
2025-10-04 18:16:08 +00:00

199 lines
5.5 KiB
Go

package auth
import (
"context"
"net/http"
"strings"
"tercul/internal/platform/log"
)
// ContextKey is a type for context keys
type ContextKey string
const (
// UserContextKey is the key for user in context
UserContextKey ContextKey = "user"
// ClaimsContextKey is the key for claims in context
ClaimsContextKey ContextKey = "claims"
)
// AuthMiddleware creates middleware for JWT authentication
func AuthMiddleware(jwtManager *JWTManager) func(http.Handler) http.Handler {
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// Skip authentication for certain paths
if shouldSkipAuth(r.URL.Path) {
next.ServeHTTP(w, r)
return
}
// Extract token from Authorization header
authHeader := r.Header.Get("Authorization")
tokenString, err := jwtManager.ExtractTokenFromHeader(authHeader)
if err != nil {
log.LogWarn("Authentication failed - missing or invalid token",
log.F("path", r.URL.Path),
log.F("error", err))
http.Error(w, "Unauthorized", http.StatusUnauthorized)
return
}
// Validate token
claims, err := jwtManager.ValidateToken(tokenString)
if err != nil {
log.LogWarn("Authentication failed - invalid token",
log.F("path", r.URL.Path),
log.F("error", err))
http.Error(w, "Unauthorized", http.StatusUnauthorized)
return
}
// Add claims to context
ctx := context.WithValue(r.Context(), ClaimsContextKey, claims)
next.ServeHTTP(w, r.WithContext(ctx))
})
}
}
// RoleMiddleware creates middleware for role-based authorization
func RoleMiddleware(requiredRole string) func(http.Handler) http.Handler {
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
claims, ok := r.Context().Value(ClaimsContextKey).(*Claims)
if !ok {
log.LogWarn("Authorization failed - no claims in context",
log.F("path", r.URL.Path),
log.F("required_role", requiredRole))
http.Error(w, "Forbidden", http.StatusForbidden)
return
}
jwtManager := NewJWTManager()
if err := jwtManager.RequireRole(claims.Role, requiredRole); err != nil {
log.LogWarn("Authorization failed - insufficient role",
log.F("path", r.URL.Path),
log.F("user_role", claims.Role),
log.F("required_role", requiredRole))
http.Error(w, "Forbidden", http.StatusForbidden)
return
}
next.ServeHTTP(w, r)
})
}
}
// GraphQLAuthMiddleware creates middleware specifically for GraphQL requests
func GraphQLAuthMiddleware(jwtManager *JWTManager) func(http.Handler) http.Handler {
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// For GraphQL, we want to authenticate but not block requests
// This allows for both authenticated and anonymous queries
authHeader := r.Header.Get("Authorization")
if authHeader != "" {
tokenString, err := jwtManager.ExtractTokenFromHeader(authHeader)
if err == nil {
claims, err := jwtManager.ValidateToken(tokenString)
if err == nil {
// Add claims to context for authenticated requests
ctx := context.WithValue(r.Context(), ClaimsContextKey, claims)
next.ServeHTTP(w, r.WithContext(ctx))
return
}
}
// If token is invalid, log warning but continue
log.LogWarn("GraphQL authentication failed - continuing with anonymous access",
log.F("path", r.URL.Path))
}
// Continue without authentication
next.ServeHTTP(w, r)
})
}
}
// GetClaimsFromContext extracts claims from context
func GetClaimsFromContext(ctx context.Context) (*Claims, bool) {
claims, ok := ctx.Value(ClaimsContextKey).(*Claims)
return claims, ok
}
// GetUserIDFromContext extracts user ID from context
func GetUserIDFromContext(ctx context.Context) (uint, bool) {
claims, ok := GetClaimsFromContext(ctx)
if !ok {
return 0, false
}
return claims.UserID, true
}
// IsAuthenticated checks if the request is authenticated
func IsAuthenticated(ctx context.Context) bool {
_, ok := GetClaimsFromContext(ctx)
return ok
}
// RequireAuth ensures the request is authenticated
func RequireAuth(ctx context.Context) (*Claims, error) {
claims, ok := GetClaimsFromContext(ctx)
if !ok {
return nil, ErrMissingToken
}
return claims, nil
}
// RequireRole ensures the user has the required role
func RequireRole(ctx context.Context, requiredRole string) (*Claims, error) {
claims, err := RequireAuth(ctx)
if err != nil {
return nil, err
}
jwtManager := NewJWTManager()
if err := jwtManager.RequireRole(claims.Role, requiredRole); err != nil {
return nil, err
}
return claims, nil
}
// shouldSkipAuth determines if authentication should be skipped for a path
func shouldSkipAuth(path string) bool {
skipPaths := []string{
"/",
"/query",
"/health",
"/metrics",
"/favicon.ico",
}
for _, skipPath := range skipPaths {
if path == skipPath {
return true
}
}
// Skip static files
if strings.HasPrefix(path, "/static/") {
return true
}
return false
}
// ContextWithUserID adds a user ID to the context for testing purposes.
func ContextWithUserID(ctx context.Context, userID uint) context.Context {
claims := &Claims{UserID: userID}
return context.WithValue(ctx, ClaimsContextKey, claims)
}
// ContextWithAdminUser adds an admin user to the context for testing purposes.
func ContextWithAdminUser(ctx context.Context, userID uint) context.Context {
claims := &Claims{
UserID: userID,
Role: "admin",
}
return context.WithValue(ctx, ClaimsContextKey, claims)
}