mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
127 lines
3.5 KiB
Go
127 lines
3.5 KiB
Go
package translation
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"tercul/internal/app/authz"
|
|
"tercul/internal/domain"
|
|
platform_auth "tercul/internal/platform/auth"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/trace"
|
|
)
|
|
|
|
// TranslationCommands contains the command handlers for the translation aggregate.
|
|
type TranslationCommands struct {
|
|
repo domain.TranslationRepository
|
|
authzSvc *authz.Service
|
|
tracer trace.Tracer
|
|
}
|
|
|
|
// NewTranslationCommands creates a new TranslationCommands handler.
|
|
func NewTranslationCommands(repo domain.TranslationRepository, authzSvc *authz.Service) *TranslationCommands {
|
|
return &TranslationCommands{
|
|
repo: repo,
|
|
authzSvc: authzSvc,
|
|
tracer: otel.Tracer("translation.commands"),
|
|
}
|
|
}
|
|
|
|
// CreateTranslationInput represents the input for creating a new translation.
|
|
type CreateTranslationInput struct {
|
|
Title string
|
|
Content string
|
|
Description string
|
|
Language string
|
|
Status domain.TranslationStatus
|
|
TranslatableID uint
|
|
TranslatableType string
|
|
TranslatorID *uint
|
|
IsOriginalLanguage bool
|
|
}
|
|
|
|
// CreateTranslation creates a new translation.
|
|
func (c *TranslationCommands) CreateTranslation(ctx context.Context, input CreateTranslationInput) (*domain.Translation, error) {
|
|
ctx, span := c.tracer.Start(ctx, "CreateTranslation")
|
|
defer span.End()
|
|
translation := &domain.Translation{
|
|
Title: input.Title,
|
|
Content: input.Content,
|
|
Description: input.Description,
|
|
Language: input.Language,
|
|
Status: input.Status,
|
|
TranslatableID: input.TranslatableID,
|
|
TranslatableType: input.TranslatableType,
|
|
TranslatorID: input.TranslatorID,
|
|
IsOriginalLanguage: input.IsOriginalLanguage,
|
|
}
|
|
err := c.repo.Create(ctx, translation)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return translation, nil
|
|
}
|
|
|
|
// UpdateTranslationInput represents the input for updating an existing translation.
|
|
type UpdateTranslationInput struct {
|
|
ID uint
|
|
Title string
|
|
Content string
|
|
Description string
|
|
Language string
|
|
Status domain.TranslationStatus
|
|
}
|
|
|
|
// UpdateTranslation updates an existing translation.
|
|
func (c *TranslationCommands) UpdateTranslation(ctx context.Context, input UpdateTranslationInput) (*domain.Translation, error) {
|
|
ctx, span := c.tracer.Start(ctx, "UpdateTranslation")
|
|
defer span.End()
|
|
userID, ok := platform_auth.GetUserIDFromContext(ctx)
|
|
if !ok {
|
|
return nil, domain.ErrUnauthorized
|
|
}
|
|
|
|
can, err := c.authzSvc.CanEditTranslation(ctx, userID, input.ID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !can {
|
|
return nil, domain.ErrForbidden
|
|
}
|
|
|
|
translation, err := c.repo.GetByID(ctx, input.ID)
|
|
if err != nil {
|
|
if errors.Is(err, domain.ErrEntityNotFound) {
|
|
return nil, fmt.Errorf("%w: translation with id %d not found", domain.ErrEntityNotFound, input.ID)
|
|
}
|
|
return nil, err
|
|
}
|
|
|
|
translation.Title = input.Title
|
|
translation.Content = input.Content
|
|
translation.Description = input.Description
|
|
translation.Language = input.Language
|
|
translation.Status = input.Status
|
|
err = c.repo.Update(ctx, translation)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return translation, nil
|
|
}
|
|
|
|
// DeleteTranslation deletes a translation by ID.
|
|
func (c *TranslationCommands) DeleteTranslation(ctx context.Context, id uint) error {
|
|
ctx, span := c.tracer.Start(ctx, "DeleteTranslation")
|
|
defer span.End()
|
|
can, err := c.authzSvc.CanDeleteTranslation(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !can {
|
|
return domain.ErrForbidden
|
|
}
|
|
|
|
return c.repo.Delete(ctx, id)
|
|
}
|