mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
49 lines
1.8 KiB
Go
49 lines
1.8 KiB
Go
package graphql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"tercul/internal/domain"
|
|
|
|
"github.com/99designs/gqlgen/graphql"
|
|
"github.com/vektah/gqlparser/v2/gqlerror"
|
|
)
|
|
|
|
// NewErrorPresenter creates a custom error presenter for gqlgen.
|
|
func NewErrorPresenter() graphql.ErrorPresenterFunc {
|
|
return func(ctx context.Context, e error) *gqlerror.Error {
|
|
gqlErr := graphql.DefaultErrorPresenter(ctx, e)
|
|
|
|
// Unwrap the error to find the root cause.
|
|
originalErr := errors.Unwrap(e)
|
|
if originalErr == nil {
|
|
originalErr = e
|
|
}
|
|
|
|
// Check for custom application errors and format them.
|
|
switch {
|
|
case errors.Is(originalErr, domain.ErrEntityNotFound):
|
|
gqlErr.Message = "The requested resource was not found."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "NOT_FOUND"}
|
|
case errors.Is(originalErr, domain.ErrUnauthorized):
|
|
gqlErr.Message = "You must be logged in to perform this action."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "UNAUTHENTICATED"}
|
|
case errors.Is(originalErr, domain.ErrForbidden):
|
|
gqlErr.Message = "You are not authorized to perform this action."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "FORBIDDEN"}
|
|
case errors.Is(originalErr, domain.ErrValidation):
|
|
// Keep the detailed message from the validation error.
|
|
gqlErr.Message = originalErr.Error()
|
|
gqlErr.Extensions = map[string]interface{}{"code": "VALIDATION_FAILED"}
|
|
case errors.Is(originalErr, domain.ErrConflict):
|
|
gqlErr.Message = "A conflict occurred with the current state of the resource."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "CONFLICT"}
|
|
default:
|
|
// For all other errors, return a generic message to avoid leaking implementation details.
|
|
gqlErr.Message = "An unexpected internal error occurred."
|
|
gqlErr.Extensions = map[string]interface{}{"code": "INTERNAL_SERVER_ERROR"}
|
|
}
|
|
|
|
return gqlErr
|
|
}
|
|
} |