mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
78 lines
2.3 KiB
Go
78 lines
2.3 KiB
Go
package search
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"tercul/internal/app/localization"
|
|
"tercul/internal/domain"
|
|
"tercul/internal/domain/work"
|
|
)
|
|
|
|
type mockLocalizationRepository struct {
|
|
mock.Mock
|
|
}
|
|
|
|
func (m *mockLocalizationRepository) GetTranslation(ctx context.Context, key string, language string) (string, error) {
|
|
args := m.Called(ctx, key, language)
|
|
return args.String(0), args.Error(1)
|
|
}
|
|
|
|
func (m *mockLocalizationRepository) GetTranslations(ctx context.Context, keys []string, language string) (map[string]string, error) {
|
|
args := m.Called(ctx, keys, language)
|
|
if args.Get(0) == nil {
|
|
return nil, args.Error(1)
|
|
}
|
|
return args.Get(0).(map[string]string), args.Error(1)
|
|
}
|
|
|
|
func (m *mockLocalizationRepository) GetAuthorBiography(ctx context.Context, authorID uint, language string) (string, error) {
|
|
args := m.Called(ctx, authorID, language)
|
|
return args.String(0), args.Error(1)
|
|
}
|
|
|
|
func (m *mockLocalizationRepository) GetWorkContent(ctx context.Context, workID uint, language string) (string, error) {
|
|
args := m.Called(ctx, workID, language)
|
|
return args.String(0), args.Error(1)
|
|
}
|
|
|
|
type mockWeaviateWrapper struct {
|
|
mock.Mock
|
|
}
|
|
|
|
func (m *mockWeaviateWrapper) IndexWork(ctx context.Context, work *work.Work, content string) error {
|
|
args := m.Called(ctx, work, content)
|
|
return args.Error(0)
|
|
}
|
|
|
|
func TestIndexService_IndexWork(t *testing.T) {
|
|
localizationRepo := new(mockLocalizationRepository)
|
|
localizationService := localization.NewService(localizationRepo)
|
|
weaviateWrapper := new(mockWeaviateWrapper)
|
|
service := NewIndexService(localizationService, weaviateWrapper)
|
|
|
|
ctx := context.Background()
|
|
testWork := work.Work{
|
|
TranslatableModel: domain.TranslatableModel{
|
|
BaseModel: domain.BaseModel{ID: 1},
|
|
Language: "en",
|
|
},
|
|
Title: "Test Work",
|
|
}
|
|
testContent := "This is the test content for the work."
|
|
|
|
// Expect a call to get the work's content.
|
|
localizationRepo.On("GetWorkContent", mock.Anything, testWork.ID, testWork.Language).Return(testContent, nil)
|
|
|
|
// Expect a call to the Weaviate wrapper with the fetched content.
|
|
weaviateWrapper.On("IndexWork", mock.Anything, &testWork, testContent).Return(nil)
|
|
|
|
err := service.IndexWork(ctx, testWork)
|
|
|
|
assert.NoError(t, err)
|
|
localizationRepo.AssertExpectations(t)
|
|
weaviateWrapper.AssertExpectations(t)
|
|
}
|