mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
50 lines
1.7 KiB
Go
50 lines
1.7 KiB
Go
package main
|
|
|
|
import (
|
|
"net/http"
|
|
"tercul/internal/adapters/graphql"
|
|
"tercul/internal/observability"
|
|
"tercul/internal/platform/auth"
|
|
|
|
"github.com/99designs/gqlgen/graphql/handler"
|
|
)
|
|
|
|
// NewServer creates a new GraphQL server with the given resolver
|
|
func NewServer(resolver *graphql.Resolver) http.Handler {
|
|
c := graphql.Config{Resolvers: resolver}
|
|
c.Directives.Binding = graphql.Binding
|
|
srv := handler.NewDefaultServer(graphql.NewExecutableSchema(c))
|
|
|
|
// Create a mux to handle GraphQL endpoint only (no playground here; served separately in production)
|
|
mux := http.NewServeMux()
|
|
mux.Handle("/query", srv)
|
|
|
|
return mux
|
|
}
|
|
|
|
// NewServerWithAuth creates a new GraphQL server with authentication and observability middleware
|
|
func NewServerWithAuth(resolver *graphql.Resolver, jwtManager *auth.JWTManager, metrics *observability.Metrics, logger *observability.Logger) http.Handler {
|
|
c := graphql.Config{Resolvers: resolver}
|
|
c.Directives.Binding = graphql.Binding
|
|
|
|
// Create the server with the custom error presenter
|
|
srv := handler.NewDefaultServer(graphql.NewExecutableSchema(c))
|
|
srv.SetErrorPresenter(graphql.NewErrorPresenter())
|
|
|
|
// Create a middleware chain. The order is important.
|
|
// Middlewares are applied from bottom to top, so the last one added is the first to run.
|
|
var chain http.Handler
|
|
chain = srv
|
|
chain = metrics.PrometheusMiddleware(chain)
|
|
// LoggingMiddleware needs to run after auth and tracing to get all context.
|
|
chain = observability.LoggingMiddleware(logger)(chain)
|
|
chain = auth.GraphQLAuthMiddleware(jwtManager)(chain)
|
|
chain = observability.TracingMiddleware(chain)
|
|
chain = observability.RequestIDMiddleware(chain)
|
|
|
|
// Create a mux to handle GraphQL endpoint
|
|
mux := http.NewServeMux()
|
|
mux.Handle("/query", chain)
|
|
|
|
return mux
|
|
} |