mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
781b313bf1
This commit addresses all the high-priority tasks outlined in the TASKS.md file, significantly improving the application's observability, completing key features, and refactoring critical parts of the codebase. ### Observability - **Centralized Logging:** Implemented a new structured, context-aware logging system using `zerolog`. A new logging middleware injects request-specific information (request ID, user ID, trace ID) into the logger, and all application logging has been refactored to use this new system. - **Prometheus Metrics:** Added Prometheus metrics for database query performance by creating a GORM plugin that automatically records query latency and totals. - **OpenTelemetry Tracing:** Fully instrumented all application services in `internal/app` and data repositories in `internal/data/sql` with OpenTelemetry tracing, providing deep visibility into application performance. ### Features - **Analytics:** Implemented like, comment, and bookmark counting. The respective command handlers now call the analytics service to increment counters when these actions are performed. - **Enrichment Tool:** Built a new, extensible `enrich` command-line tool to fetch data from external sources. The initial implementation enriches author data using the Open Library API. ### Refactoring & Fixes - **Decoupled Testing:** Refactored the testing utilities in `internal/testutil` to be database-agnostic, promoting the use of mock-based unit tests and improving test speed and reliability. - **Build Fixes:** Resolved numerous build errors, including a critical import cycle between the logging, observability, and authentication packages. - **Search Service:** Fixed the search service integration by implementing the `GetWorkContent` method in the localization service, allowing the search indexer to correctly fetch and index work content.
52 lines
1.4 KiB
Go
52 lines
1.4 KiB
Go
package sql
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"tercul/internal/domain"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
type editionRepository struct {
|
|
domain.BaseRepository[domain.Edition]
|
|
db *gorm.DB
|
|
tracer trace.Tracer
|
|
}
|
|
|
|
// NewEditionRepository creates a new EditionRepository.
|
|
func NewEditionRepository(db *gorm.DB) domain.EditionRepository {
|
|
return &editionRepository{
|
|
BaseRepository: NewBaseRepositoryImpl[domain.Edition](db),
|
|
db: db,
|
|
tracer: otel.Tracer("edition.repository"),
|
|
}
|
|
}
|
|
|
|
// ListByBookID finds editions by book ID
|
|
func (r *editionRepository) ListByBookID(ctx context.Context, bookID uint) ([]domain.Edition, error) {
|
|
ctx, span := r.tracer.Start(ctx, "ListByBookID")
|
|
defer span.End()
|
|
var editions []domain.Edition
|
|
if err := r.db.WithContext(ctx).Where("book_id = ?", bookID).Find(&editions).Error; err != nil {
|
|
return nil, err
|
|
}
|
|
return editions, nil
|
|
}
|
|
|
|
// FindByISBN finds an edition by ISBN
|
|
func (r *editionRepository) FindByISBN(ctx context.Context, isbn string) (*domain.Edition, error) {
|
|
ctx, span := r.tracer.Start(ctx, "FindByISBN")
|
|
defer span.End()
|
|
var edition domain.Edition
|
|
if err := r.db.WithContext(ctx).Where("isbn = ?", isbn).First(&edition).Error; err != nil {
|
|
if errors.Is(err, gorm.ErrRecordNotFound) {
|
|
return nil, ErrEntityNotFound
|
|
}
|
|
return nil, err
|
|
}
|
|
return &edition, nil
|
|
}
|