mirror of
https://github.com/SamyRai/tercul-backend.git
synced 2025-12-27 05:11:34 +00:00
9fd2331eb4
This commit introduces a comprehensive set of foundational improvements to make the API more robust, secure, and observable. The following features have been implemented: - **Observability Stack:** A new `internal/observability` package has been added, providing structured logging with `zerolog`, Prometheus metrics, and OpenTelemetry tracing. This stack is fully integrated into the application's request pipeline. - **Centralized Authorization:** A new `internal/app/authz` service has been created to centralize authorization logic. This service is now used by the `user`, `work`, and `comment` services to protect all Create, Update, and Delete operations. - **Standardized Input Validation:** The previous ad-hoc validation has been replaced with a more robust, struct-tag-based system using the `go-playground/validator` library. This has been applied to all GraphQL input models. - **Structured Error Handling:** A new set of custom error types has been introduced in the `internal/domain` package. A custom `gqlgen` error presenter has been implemented to map these domain errors to structured GraphQL error responses with specific error codes. - **`updateUser` Endpoint:** The `updateUser` mutation has been fully implemented as a proof of concept for the new patterns, including support for partial updates and comprehensive authorization checks. - **Test Refactoring:** The test suite has been significantly improved by decoupling mock repositories from the shared `testutil` package, resolving circular dependency issues and making the tests more maintainable.
33 lines
916 B
Go
33 lines
916 B
Go
package graphql
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
"tercul/internal/domain"
|
|
|
|
"github.com/go-playground/validator/v10"
|
|
)
|
|
|
|
// The 'validate' variable is declared in binding.go and is used here.
|
|
|
|
// Validate performs validation on a struct using the validator library.
|
|
func Validate(s interface{}) error {
|
|
err := validate.Struct(s)
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
|
|
var validationErrors validator.ValidationErrors
|
|
if errors.As(err, &validationErrors) {
|
|
var errorMessages []string
|
|
for _, err := range validationErrors {
|
|
// Customize error messages here if needed.
|
|
errorMessages = append(errorMessages, fmt.Sprintf("field '%s' failed on the '%s' tag", err.Field(), err.Tag()))
|
|
}
|
|
return fmt.Errorf("%w: %s", domain.ErrValidation, strings.Join(errorMessages, "; "))
|
|
}
|
|
|
|
// For other unexpected errors, like invalid validation input.
|
|
return fmt.Errorf("unexpected error during validation: %w", err)
|
|
} |